Skip to content

Commit

Permalink
added version to the signing config message. (#383)
Browse files Browse the repository at this point in the history
Signed-off-by: Fredrik Skogman <[email protected]>
  • Loading branch information
kommendorkapten authored Aug 22, 2024
1 parent 0606c22 commit ea7269b
Show file tree
Hide file tree
Showing 9 changed files with 36 additions and 3 deletions.
4 changes: 4 additions & 0 deletions gen/jsonschema/schemas/ClientTrustConfig.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@
},
"dev.sigstore.trustroot.v1.SigningConfig": {
"properties": {
"mediaType": {
"type": "string",
"description": "MUST be application/vnd.dev.sigstore.signingconfig.v0.1+json"
},
"caUrl": {
"type": "string",
"description": "A URL to a Fulcio-compatible CA, capable of receiving Certificate Signing Requests (CSRs) and responding with issued certificates. This URL **MUST** be the \"base\" URL for the CA, which clients should construct an appropriate CSR endpoint on top of. For example, if `ca_url` is `https://example.com/ca`, then the client **MAY** construct the CSR endpoint as `https://example.com/ca/api/v2/signingCert`."
Expand Down
4 changes: 4 additions & 0 deletions gen/jsonschema/schemas/SigningConfig.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
"definitions": {
"SigningConfig": {
"properties": {
"mediaType": {
"type": "string",
"description": "MUST be application/vnd.dev.sigstore.signingconfig.v0.1+json"
},
"caUrl": {
"type": "string",
"description": "A URL to a Fulcio-compatible CA, capable of receiving Certificate Signing Requests (CSRs) and responding with issued certificates. This URL **MUST** be the \"base\" URL for the CA, which clients should construct an appropriate CSR endpoint on top of. For example, if `ca_url` is `https://example.com/ca`, then the client **MAY** construct the CSR endpoint as `https://example.com/ca/api/v2/signingCert`."
Expand Down
15 changes: 13 additions & 2 deletions gen/pb-go/trustroot/v1/sigstore_trustroot.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions gen/pb-ruby/lib/sigstore_trustroot_pb.rb

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,9 @@ pub struct TrustedRoot {
#[allow(clippy::derive_partial_eq_without_eq)]
#[derive(Clone, PartialEq, ::prost::Message)]
pub struct SigningConfig {
/// MUST be application/vnd.dev.sigstore.signingconfig.v0.1+json
#[prost(string, tag = "5")]
pub media_type: ::prost::alloc::string::String,
/// A URL to a Fulcio-compatible CA, capable of receiving
/// Certificate Signing Requests (CSRs) and responding with
/// issued certificates.
Expand Down
Binary file not shown.
6 changes: 5 additions & 1 deletion gen/pb-typescript/src/__generated__/sigstore_trustroot.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions protos/sigstore_trustroot.proto
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,9 @@ message TrustedRoot {
// signing. In particular, it primarily contains service URLs that a Sigstore
// signer may need to connect to for the online aspects of signing.
message SigningConfig {
// MUST be application/vnd.dev.sigstore.signingconfig.v0.1+json
string media_type = 5;

// A URL to a Fulcio-compatible CA, capable of receiving
// Certificate Signing Requests (CSRs) and responding with
// issued certificates.
Expand Down

0 comments on commit ea7269b

Please sign in to comment.