WIP feat: Use manifest #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
requested review from
mihaimaruseac,
smeiklej and
haydentherapper
as code owners
laurentsimon
force-pushed
the
feat/manifest
branch
from
677bae9 to
9291d34
Compare
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
laurentsimon
force-pushed
the
feat/manifest
branch
from
bfd0d70 to
70679fa
Compare
Signed-off-by: laurentsimon <[email protected]>
|
This is now working with sigstore/sigstore-python#962 High-level:
The pre-submit fail because we need to pull the branch from sigstore/sigstore-python#962 |
3 tasks
|
This is great! Thank you! |
Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
susperius
reviewed
Apr 24, 2024
| files += [f] | ||
| stmt = ( | ||
| dsse._StatementBuilder() | ||
| .subjects( |
There was a problem hiding this comment.
Shouldn't the subjects be the files?
My mental model had the statement subjects as the artifacts we want to sign so you get subject[n].name = path and subject[n].digest = file_hash. So we would only set the predicate_type field as sigstore.dev/model-transparency/manifest/v1 and that describes everything we need to know about the subjects. Furthermore, the predicate could then hold metadata like {"hash_algorithm": "abc"}.
PLMK if there is something I don't get here.
See https://github.com/in-toto/attestation/blob/main/spec/v1/statement.md
There was a problem hiding this comment.
You're correct that's how intoto works, but there is some discussion here about whether we want to use intoto or not #111
For this PR, I could not pack files in the subject due to some current limitation on the hash type accepted by sigstore-python library (they only accept known hashes, but we use a parallel hash). And I could not use a non-intoto payload for this PoC, because sigstore-python does not support it yet (WIP).
mihaimaruseac
added a commit
to mihaimaruseac/model-transparency
that referenced
this pull request
Jun 4, 2024
This is the middle layer of the API design work (sigstore#172). We add a manifest abstract class to represent various manifests (sigstore#111 sigstore#112) and also ways to serialize a model directory into manifests and ways to verify the manifests. For now, this only does what was formerly known as `serialize_v0`. The v1 and the manifest versions will come soon. Note: This has a lot of inspiration from sigstore#112, but makes the API work with all the usecases we need to consider right now. Signed-off-by: Mihai Maruseac <[email protected]>
mihaimaruseac
added a commit
to mihaimaruseac/model-transparency
that referenced
this pull request
Jun 4, 2024
This is the middle layer of the API design work (sigstore#172). We add a manifest abstract class to represent various manifests (sigstore#111 sigstore#112) and also ways to serialize a model directory into manifests and ways to verify the manifests. For now, this only does what was formerly known as `serialize_v0`. The v1 and the manifest versions will come soon. Note: This has a lot of inspiration from sigstore#112, but makes the API work with all the usecases we need to consider right now. Signed-off-by: Mihai Maruseac <[email protected]>
mihaimaruseac
added a commit
to mihaimaruseac/model-transparency
that referenced
this pull request
Jun 4, 2024
This is the middle layer of the API design work (sigstore#172). We add a manifest abstract class to represent various manifests (sigstore#111 sigstore#112) and also ways to serialize a model directory into manifests and ways to verify the manifests. For now, this only does what was formerly known as `serialize_v0`. The v1 and the manifest versions will come soon. Note: This has a lot of inspiration from sigstore#112, but makes the API work with all the usecases we need to consider right now. Signed-off-by: Mihai Maruseac <[email protected]>
mihaimaruseac
added a commit
that referenced
this pull request
Jun 5, 2024
) * Migrate `serialize_v0` to new API. This is the middle layer of the API design work (#172). We add a manifest abstract class to represent various manifests (#111 #112) and also ways to serialize a model directory into manifests and ways to verify the manifests. For now, this only does what was formerly known as `serialize_v0`. The v1 and the manifest versions will come soon. Note: This has a lot of inspiration from #112, but makes the API work with all the usecases we need to consider right now. Signed-off-by: Mihai Maruseac <[email protected]> * Clarify some comments Signed-off-by: Mihai Maruseac <[email protected]> * Encode name with base64 Signed-off-by: Mihai Maruseac <[email protected]> * Add another test case Signed-off-by: Mihai Maruseac <[email protected]> * Empty commit to retrigger DCO check. See dcoapp/app#211 (comment) Signed-off-by: Mihai Maruseac <[email protected]> --------- Signed-off-by: Mihai Maruseac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #111
blocked on sigstore/sigstore-python#628