attest: force https for rekor client #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlynch
force-pushed
the
attest-rekor-https
branch
from
2736ade to
590d033
Compare
For some reason this defaults to http, which results in the server terminating the request (my guess is this was previously redirecting http->https before). This changes forces the https scheme (hopefully this isn't disruptive for non-public good instances, but we can revisit other changes later if we need to). Signed-off-by: Billy Lynch <[email protected]>
wlynch
force-pushed
the
attest-rekor-https
branch
from
590d033 to
04d1993
Compare
adityasaky
approved these changes
Jan 3, 2025
cpanato
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For some reason this defaults to http, which results in the server terminating the request (my guess is this was previously redirecting http->https before). This changes forces the https scheme (hopefully this isn't disruptive for non-public good instances, but we can revisit other changes later if we need to).
We should setup e2e tests for attest so we can catch this other disruptions to attest, but will do this in another PR so we can get this fix in.
Release Note
gitsign attestDocumentation