Skip to content

Conversation

@jku
Copy link
Member

@jku jku commented Nov 2, 2025

  • Add script for creating venvs in a way that
    • uses uv without requiring it to be installed
    • controls the used Python version with .python-version file
  • Use the script in Makefile and action setup
  • Be sure to treat Windows as the special case it is with regards to venv bin directory

I believe this fixes #235 and #236 (by controlling the used python version in the venv we use, currently set to 3.14). Also makes #238 not needed.

@jku jku marked this pull request as draft November 2, 2025 12:57
@jku jku force-pushed the manage-python-version branch from f260d82 to e396e9c Compare November 2, 2025 13:08
@jku jku linked an issue Nov 2, 2025 that may be closed by this pull request
@jku jku force-pushed the manage-python-version branch from e396e9c to fde8204 Compare November 3, 2025 10:38
@jku jku marked this pull request as ready for review November 3, 2025 10:40
@jku
Copy link
Member Author

jku commented Nov 3, 2025

I think this works and is better than the other PR: This one actually solves the linked issues by managing the Python internally. Marked ready for review

* Add script for creating venvs in a way that
   * uses uv without requiring it to be installed
   * controls the used Python version with .python-version file
* Use the script in Makefile and action setup
* Be sure to treat Windows as the special case it is with regards to
  venv bin directory

Signed-off-by: Jussi Kukkonen <[email protected]>
@jku jku force-pushed the manage-python-version branch from fde8204 to 6ce7f53 Compare November 3, 2025 11:32
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(I would be okay with us having a hard dependency on uv, for the record. But I'm also okay with this kind of bootstrapping 🙂)

@woodruffw woodruffw merged commit 582cce9 into main Nov 3, 2025
34 checks passed
@woodruffw woodruffw deleted the manage-python-version branch November 3, 2025 16:01
@jku jku mentioned this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start managing Python version within the action v3.1.0 fails on python < 3.10 (default python on windows runners is 3.9)

3 participants