Actually upgrade dependencies #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test with 3.x on all platforms * test with 3.14 (as 3.x+1) on all platforms * test with the the runner provided python on ubuntu Signed-off-by: Jussi Kukkonen <[email protected]>
It looks like dependabot will only upgrade if the constraints require it. Upgrade manually for now. This should fix #215. Signed-off-by: Jussi Kukkonen <[email protected]>
woodruffw
reviewed
Oct 16, 2025
Comment on lines
+22
to
+23
| - os: ubuntu-latest | ||
| python-version: platform-default |
There was a problem hiding this comment.
Confirming I understand: this ensures that our action works with the runner-provided Python version on Ubuntu runners?, right?
There was a problem hiding this comment.
yes: I'm not sure it's needed but that case was specifically tested by the "ubuntu-latest" case in the current workflow so I preserved it here
woodruffw
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uv pip compile --upgrade ...to upgrade all dependencies (even if our constraints do not require it) as it seems it is not possible to get dependabot to do that (Investigate upgrade solutions (yet again) #223)Fixes #215