Skip to content

cleanup some zizmor-flagged issues in actions#1910

Merged
cpanato merged 3 commits intosigstore:mainfrom
bobcallaway:zizmor
Jan 15, 2025
Merged

cleanup some zizmor-flagged issues in actions#1910
cpanato merged 3 commits intosigstore:mainfrom
bobcallaway:zizmor

Conversation

@bobcallaway
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from cpanato January 15, 2025 12:49
Comment thread .github/workflows/codeql-analysis.yml
Comment thread .github/workflows/codeql-analysis.yml Outdated
cpanato
cpanato previously approved these changes Jan 15, 2025
Copy link
Copy Markdown
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some are here :)

#1909

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.13%. Comparing base (cf238ac) to head (3c8575a).
Report is 274 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1910      +/-   ##
==========================================
- Coverage   57.93%   49.13%   -8.80%     
==========================================
  Files          50       70      +20     
  Lines        3119     5204    +2085     
==========================================
+ Hits         1807     2557     +750     
- Misses       1154     2413    +1259     
- Partials      158      234      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobcallaway
Copy link
Copy Markdown
Member Author

some are here :)

#1909

lol, didn't see this. let me review/merge yours and i'll fix this up after.

Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from cpanato January 15, 2025 13:13
@cpanato cpanato merged commit 1525d5d into sigstore:main Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants