-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1 go tuf update #3598
V1 go tuf update #3598
Conversation
Signed-off-by: Fredrik Skogman <[email protected]>
Signed-off-by: Fredrik Skogman <[email protected]>
swap out deprecated lib Signed-off-by: Bob Callaway <[email protected]>
swap out deprecated lib Signed-off-by: Bob Callaway <[email protected]>
fix gofmt issue Signed-off-by: Bob Callaway <[email protected]>
go mod tidy Signed-off-by: Bob Callaway <[email protected]>
free up space ahead of running goreleaser Signed-off-by: Bob Callaway <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.13 #3598 +/- ##
================================================
- Coverage 30.14% 29.73% -0.42%
================================================
Files 136 137 +1
Lines 8443 8560 +117
================================================
Hits 2545 2545
- Misses 5568 5685 +117
Partials 330 330 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpanato any concerns with adding this to the release-1.13 branch? and anything special we need to know about triggering a release for 1.13.2?
@haydentherapper nothing, will be similar from the previous one. but this will be the last for the branch? or how long will we maintain this? |
I would hope this would be the last update for v1, i.e we won't continue to maintain it anymore. But of course, I'm not the authoritative person to make such a decision :) |
Do we have any data on how many people are still downloading or using cosign v1? |
I’m still skeptical that we need this. Kyverno was the only major customer I was aware of but they’ve upgraded to v2. We could hold off on merging until after the root is upgraded and see if there’s any complaints from v1 users? |
Only kyverno was asking in the past. I think we can hold this for a while |
We've had a request for it, so moving forward it this. |
Summary
Per the latest sigstore/root-signing#1164 in Sigstore Public Good instance, the key type is changing for the TUF keys, to keep cosign v1 continue to work I've updated to the latest go-tuf version.
This is the same PR as #3597 but against
release-1.13
branch. We should probably push it to a new branch instead, but opening to get all the tests to run.Release Note
Documentation
N/A