-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support basic auth and bearer auth login to registry #3310
Conversation
9e37941
to
e89f4ab
Compare
@haydentherapper Could you please review this pr? |
Codecov Report
@@ Coverage Diff @@
## main #3310 +/- ##
==========================================
- Coverage 30.65% 30.61% -0.04%
==========================================
Files 155 155
Lines 9994 10007 +13
==========================================
Hits 3064 3064
- Misses 6474 6487 +13
Partials 456 456
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it lgtm
but wondering if we can rely on the existing auth like when you do docker login
...
Yes, |
Signed-off-by: Tosone <[email protected]>
@haydentherapper gently ping. |
Summary
In some scenarios, user wants to login the registry in oneline command. trivy can be used like this:
trivy image --registry-token xx image
Release Note
Support basic auth and bearer auth login to registry