Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --output-certificate not working properly #1149

Merged
merged 1 commit into from
Dec 7, 2021
Merged

fix: --output-certificate not working properly #1149

merged 1 commit into from
Dec 7, 2021

Conversation

caarlos0
Copy link
Contributor

@caarlos0 caarlos0 commented Dec 7, 2021

Summary

--output-certificate was producing empty certificates.
Likely a bad merge from me when working on #1095

Ticket Link

Refs #1095

Release Note

fix sign-blob --output-certificate writing an empty file

@dekkagaijin dekkagaijin merged commit 26c99d8 into sigstore:main Dec 7, 2021
@github-actions github-actions bot added this to the v1.4.0 milestone Dec 7, 2021
@caarlos0 caarlos0 deleted the fix-sign branch December 7, 2021 01:07
@cpanato cpanato modified the milestones: v1.4.0, v1.4.1 Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants