Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sign output to note when signatures are pushed #1117

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

haydentherapper
Copy link
Contributor

This updates the output for cosign sign to match what's in the documentation. A few other output cleanups:

  • Changed when the newline is written for fetching a password
  • Removed writing the signature to stdout, only writing the signature to a file when requested

New output:

$ ~/go/bin/cosign sign --key cosign.key us-west1-docker.pkg.dev/project/docker-repo/image:tag1
Enter password for private key:
Pushing signature to: us-west1-docker.pkg.dev/project/docker-repo/image

Previous output:

$ ~/go/bin/cosign sign --key cosign.key us-west1-docker.pkg.dev/project/docker-repo/image:tag1
Enter password for private key: MEYCI....

Release Note

NONE

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@dlorenc dlorenc merged commit 034e946 into sigstore:main Dec 1, 2021
@github-actions github-actions bot added this to the v1.4.0 milestone Dec 1, 2021
@haydentherapper haydentherapper deleted the cleanup-output branch December 1, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants