minor: plumb context through to tlog requests
#1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekkagaijin
changed the title
context through to tlog requestscontext through to tlog requests
mattmoor
reviewed
Nov 24, 2021
cmd/cosign/cli/attest/attest.go
Outdated
| @@ -67,6 +67,12 @@ func AttestCmd(ctx context.Context, ko sign.KeyOpts, regOpts options.RegistryOpt | |||
| return errors.Wrap(err, "parsing reference") | |||
| } | |||
|
|
|||
| if timeout != time.Duration(0) { | |||
There was a problem hiding this comment.
This reads a lot better
Suggested change
| if timeout != time.Duration(0) { | |
| if timeout != 0 { |
mattmoor
reviewed
Nov 24, 2021
cmd/cosign/cli/sign/sign.go
Outdated
| @@ -135,6 +134,13 @@ func SignCmd(ctx context.Context, ko KeyOpts, regOpts options.RegistryOptions, a | |||
| } | |||
| } | |||
|
|
|||
| // TODO - Defaulting the timeout to zero as the CLI doesn't accept timeout. | |||
There was a problem hiding this comment.
IDK how to interpret the work needed to address this TODO
dekkagaijin
force-pushed
the
tlog-ctx
branch
from
fd6c07a
to
aa848e8
Compare
Signed-off-by: Jake Sanders <[email protected]>
dekkagaijin
force-pushed
the
tlog-ctx
branch
from
aa848e8
to
f66c007
Compare
mattmoor
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
timeoutargument unnecessary