Add PKCS11 tag in releaser and Makefile for Mac and Windows #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kieran Miller <[email protected]>
|
Cc @cpanato can you take a look at this one? |
|
do we need to generate two binaries one with |
I think it should be fine to do one for both. |
Signed-off-by: Kieran Miller <[email protected]>
cpanato
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kieran Miller [email protected]
Summary
This PR adds the
pkcs11keytag for both Mac and Windows releases.It also creates a new release
linux-pivkey-pkcs11key-amd64which supports both PIV and PKCS11 keys, and adds its corresponding targetcosign-pivkey-pkcs11keyin the Makefile.Ticket Link
Release Note