-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verify-blob: add URI to verify-blob output #1047
Conversation
@dlorenc do you know how I get this information here?
Is it encoded as ASN1 struct in one of the other certificate fields? |
d65d50d
to
e1d4673
Compare
This part works for printing the certificate extension: for _, ext := range cert.Extensions {
oidc := asn1.ObjectIdentifier{1,3,6,1,4,1,57264,1,1}
if ext.Id.Equal(oidc) {
fmt.Fprintln(os.Stderr, "1.3.6.1.4.1.57264.1.1: ", string(ext.Value))
}
} But I have no idea if we might encounter more of these and if the certificate extension is always the same. |
e1d4673
to
1401096
Compare
I am not really convinced yet if printing the x509 extension/object identifier value is a good idea. And throwing all values to the user might be more confusing than it actually helps. If the object identifier stays the same, it makes sense to include it. If not, we might just use the URIs?! |
We should print the URIs mentioned in the certificate, if there are any. Signed-off-by: Christian Rebischke <[email protected]>
1401096
to
c48e4ec
Compare
New Output:
|
@dlorenc Would it make sense to give verify operations a format flag for machine-readable output? Or is this over the top? |
I think this makes sense, just a plain json output? |
Yes, just a plain json output, but I think it makes sense to address this in another issue. If we implement a format flag, we have to stay persistent with the JSON schema. People would rely on it, because it is machine readable. I will create a separate issue for this. |
Done: Separate Issue for JSON output: #1048 |
Summary
Adds an URI field to the verify-blob output.
Before this PR:
After this PR:
Ticket Link
Fixes #1046
Release Note