Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test serde deserialization #62

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Test serde deserialization #62

merged 1 commit into from
Feb 14, 2025

Conversation

michaelsproul
Copy link
Member

Inspired by @pawanjay176's PR to ssz_types, these tests ensure that milhouse's Deserialize implementations maintain length invariants. They do!

See also:

pawanjay176
pawanjay176 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, nice to see we are already doing this here!

@michaelsproul michaelsproul merged commit 56a3bd1 into main Feb 14, 2025
5 checks passed
@michaelsproul michaelsproul deleted the test-serde branch February 14, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsproul @pawanjay176