Fix ci issues - #9514
Merged
Merged
Conversation
Member
Author
|
ignore flaky ci issue this should be g2g |
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
Bot
added
waiting-on-author
michaelsproul
approved these changes
Jun 22, 2026
michaelsproul
left a comment
michaelsproul
left a comment
Member
There was a problem hiding this comment.
happy to merge as is to just fix CI
| [[package]] | ||
| name = "data-encoding-macro" | ||
| version = "0.1.19" | ||
| version = "0.1.18" |
Member
There was a problem hiding this comment.
is this the root cause of the syn thing? seems weird to downgrade this
I think just changing syn 1 to 2 also works
this is some weird cargo stuff we haven't got to the bottom of
Member
There was a problem hiding this comment.
The rust-libp2p update here seems to have updated data-encoding-macro which downgraded syn
|
Queued — the merge queue status continues in this comment ↓. |
Merge Queue Status
This pull request spent 29 minutes 30 seconds in the queue, including 27 minutes 59 seconds running CI. Required conditions to merge
|
michaelsproul
added
ready-for-merge
8 tasks
dknopik
pushed a commit
to dknopik/lighthouse
that referenced
this pull request
Jul 9, 2026
- Remove deprecated geth flag - Remove duplicate entries for crate `syn`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
syn