Skip to content

Forbid removed execution_payload_envelope.rs file - #9506

Merged
mergify[bot] merged 2 commits into
sigp:unstablefrom
macladson:remove-envelope-file
Jun 23, 2026
Merged

Forbid removed execution_payload_envelope.rs file#9506
mergify[bot] merged 2 commits into
sigp:unstablefrom
macladson:remove-envelope-file

Conversation

@macladson

Copy link
Copy Markdown
Member

Issue Addressed

I noticed that beacon_node/http_api/src/beacon/execution_payload_envelope.rs was recently removed but not added to the forbidden-files.txt.

Proposed Changes

Add the removed file to the forbidden list to ensure it isn't accidentally re-added by a merge or rebase.

@macladson macladson added code-quality low-hanging-fruit Easy to resolve, get it before someone else does! labels Jun 18, 2026
@macladson
macladson marked this pull request as ready for review June 18, 2026 14:42
@macladson
macladson requested a review from michaelsproul as a code owner June 18, 2026 14:42
@chong-he

Copy link
Copy Markdown
Member

I think it's a rename of the file due to pluralized: #9418

@macladson

Copy link
Copy Markdown
Member Author

I think it's a rename of the file due to pluralized: #9418

Yes that's right, it was moved. But merges and rebases can still attempt to re-add it with the old name

@macladson macladson added the ready-for-review The code is ready for review label Jun 19, 2026

@chong-he chong-he left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mergify

mergify Bot commented Jun 22, 2026

Copy link
Copy Markdown

Queued — the merge queue status continues in this comment ↓.

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jun 22, 2026
@mergify

mergify Bot commented Jun 22, 2026

Copy link
Copy Markdown

Merge Queue Status

This pull request spent 29 minutes 13 seconds in the queue, including 27 minutes 23 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Jun 22, 2026
mergify Bot added a commit that referenced this pull request Jun 22, 2026
mergify Bot added a commit that referenced this pull request Jun 22, 2026
mergify Bot added a commit that referenced this pull request Jun 22, 2026
@mergify
mergify Bot merged commit 34e14fd into sigp:unstable Jun 23, 2026
38 checks passed
@mergify mergify Bot removed the queued label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants