Gloas payload cache#9209
Merged
Merged
Conversation
…oas-data-availability-checker
…data-availability-checker
…oas-data-availability-checker
|
Some required checks have failed. Could you please take a look @dknopik? 🙏 |
… Restores `PriorKnownUnpublished` error when all cells are already in the DA cache, which makes the API return the configured `duplicate_status_code`.
…uth to avoid having to add extra checks.
jimmygchen
approved these changes
May 13, 2026
Member
jimmygchen
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments @eserilev
I've fixed the conflicts with unstable and also reverted the commit "PriorKnownUnpublished should still propagate columns" *(973590a) to fix CI as it caused a regression.
GossipDataColumnError::PriorKnownUnpublished occurs when we have blobs from the EL, but have not publish some of the columns due to gradual column publication
- they are scheduled to be published in the background, and we don't want to re-process them again hence we want to return None during block publishing.
Merge Queue Status
This pull request spent 29 minutes 21 seconds in the queue, including 27 minutes 27 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
In Gloas, beacon blocks are imported into fork choice immediately - the payload envelope and data columns arrive
separately. KZG commitments moved from the column sidecar into the execution payload bid, so the existing
DataAvailabilityChecker(which assumes block and data are coupled) can't be used for Gloas.Proposed Changes
PendingPayloadCacheto keep track of payload and data columns per block root.MaybeAvailableEnvelope,ExecutedEnvelope,EnvelopeImportDataNot yet implemented (tracked with TODOs):
load_gloas_payload_biddisk reads off the async runtimeBased on @eserilev's PR and work in progress. See also #9202 for verification.