Add Gloas SSE event boilerplate - #9053
Merged
Merged
Conversation
Member
|
Good idea splitting out the boiler plate btw! |
Merge Queue Status
This pull request spent 27 minutes 46 seconds in the queue, including 26 minutes 16 seconds running CI. Required conditions to merge
|
10 tasks
This was referenced Mar 31, 2026
dapplion
pushed a commit
that referenced
this pull request
Mar 31, 2026
Implement boilerplate for new SSE events as specified in - ethereum/beacon-APIs#588 While that one is not merged yet, I believe the SSE events might be utilized in Dora already. Implement the boilerplate, i.e. subscription tracking and publish queues. A PR to implement to fully implement already implementable events will follow. Co-Authored-By: Daniel Knopik <daniel@dknopik.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Implement boilerplate for new SSE events as specified in
execution_payloadandexecution_payload_gossipevent ethereum/beacon-APIs#588While that one is not merged yet, I believe the SSE events might be utilized in Dora already.
Proposed Changes
Implement the boilerplate, i.e. subscription tracking and publish queues. A PR to implement to fully implement already implementable events will follow.
Additional Info
Let me know if you prefer one PR per new event type (with full integration) instead.
AI assisted.