Update to spec v1.7.0-alpha.4 - #9046
Merged
Merged
Conversation
michaelsproul
added
spec_change
michaelsproul
commented
Mar 30, 2026
| .ok_or(BeaconStateError::SlotOutOfBounds)?; | ||
|
|
||
| // Convert from FixedVector<u64, PTCSize> to PTC<E> (FixedVector<usize, PTCSize>) | ||
| let indices: Vec<usize> = entry.iter().map(|&v| v as usize).collect(); |
michaelsproul
added
ready-for-review
Member
Author
|
Ready for review! |
jimmygchen
reviewed
Mar 31, 2026
dapplion
approved these changes
Mar 31, 2026
dapplion
left a comment
dapplion
left a comment
Collaborator
There was a problem hiding this comment.
Impl matches spec, and the optimizations make sense. ptc_window takes 393,216 bytes on the mainnet config so it's worthwhile to mem share
jimmygchen
approved these changes
Mar 31, 2026
jimmygchen
left a comment
jimmygchen
left a comment
Member
There was a problem hiding this comment.
Looks pretty clean to me 👍
jimmygchen
added
ready-for-merge
Merge Queue Status
This pull request spent 29 minutes 20 seconds in the queue, including 27 minutes 34 seconds running CI. Required conditions to merge
|
10 tasks
dapplion
pushed a commit
that referenced
this pull request
Mar 31, 2026
Update our consensus code to v1.7.0-alpha.4 Co-Authored-By: Michael Sproul <michael@sigmaprime.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Update our consensus code to v1.7.0-alpha.4
Additional Info
This includes some of the ChainSpec fixes from:
ChainSpecconsistency with upstreamconfig.yaml#9008AI-assisted.