Gloas payload envelope processing [WIP]#8806
Open
eserilev wants to merge 16 commits intosigp:unstablefrom
Open
Gloas payload envelope processing [WIP]#8806eserilev wants to merge 16 commits intosigp:unstablefrom
eserilev wants to merge 16 commits intosigp:unstablefrom
Conversation
…oas-payload-processing
…oas-payload-processing
…oas-payload-processing
…oas-payload-processing
jimmygchen
changed the title
…oas-payload-processing
…oas-payload-processing
eserilev
commented
Feb 23, 2026
Comment on lines
+163
to
+167
| // TODO(gloas) are these other logs important? | ||
| root = ?beacon_block_root, | ||
| // graffiti = block.body().graffiti().as_utf8_lossy(), | ||
| // proposer_index = block.proposer_index(), | ||
| // slot = %block.slot(), |
Member
Author
There was a problem hiding this comment.
we wont have this info post gloas, I'd like to delete these fields if thats okay
eserilev
commented
Feb 23, 2026
Comment on lines
+209
to
+213
| // TODO(gloas) are these other logs important? | ||
| root = ?beacon_block_root, | ||
| // graffiti = block.body().graffiti().as_utf8_lossy(), | ||
| // proposer_index = block.proposer_index(), | ||
| // slot = %block.slot(), |
Member
Author
There was a problem hiding this comment.
would like to delete these as well
Member
Author
|
This one should be ready for a first pass |
Member
Author
|
I tried looking at removing the beacon chain dependency from the gossip path. It didn't seem to make unit testing that much easier, the dependency on |
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
bot
added
waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement payload envelope gossip verification and processing