fix: remove dead restart_failed_sync from custody backfill #8553
Conversation
|
|
|
|
| // Check if we need to restart custody backfill sync due to a cgc change. | ||
| if self.restart_if_required() { | ||
| return Ok(ProcessResult::Successful); | ||
| } |
There was a problem hiding this comment.
what is the reasoning for deleting this?
|
we probably want to keep |
eserilev
added
waiting-on-author
| // inform the backfill sync that a new synced peer has joined us. | ||
| if new_state.is_synced() { | ||
| self.backfill_sync.fully_synced_peer_joined(); | ||
| self.custody_backfill_sync.fully_synced_peer_joined(); |
There was a problem hiding this comment.
i don't think we want to remove this, i think we want to actually get restart_failed_sync to work appropriately
ANtutov
force-pushed
the
fix/custody-backfill-dead-restart-flag
branch
from
bf01ec8 to
a84a1cb
Compare
|
Also squashed tp reduce noise in commits |
|
please read my comment above. We probably want to keep restard_failed_sync and fix its usage instead of deleting it |
2 participants
Custody backfill no longer uses the restart_failed_sync flag to gate restarts and never reads it, unlike the regular backfill logic. This change removes the unused field and its assignments from CustodyBackFillSync, drops the call from SyncManager, and leaves fully_synced_peer_joined as an explicit no-op for API symmetry