Skip to content

Conversation

@Andrurachi
Copy link

@Andrurachi Andrurachi commented Nov 25, 2025

Issue Addressed

Closes #8426

Proposed Changes

Added a new regression test: reproduction_unaligned_checkpoint_sync_pruned_payload.

This test reproduces the bug where unaligned checkpoint syncs (skipped slots at epoch boundaries) fail to import the anchor block's execution payload when prune_payloads is enabled.

The test simulates the failure mode by:

  • Skipping if execution payloads are not applicable.
  • Creating a harness with an unaligned checkpoint (gap of 3 slots).
  • Configuring the client with prune_payloads = true.

It asserts that the Beacon Chain builds successfully (previously it panicked with MissingFullBlockExecutionPayloadPruned), confirming the fix logic in try_get_full_block.

@cla-assistant
Copy link

cla-assistant bot commented Nov 25, 2025

CLA assistant check
All committers have signed the CLA.

@Andrurachi Andrurachi marked this pull request as draft November 25, 2025 16:37
This adds a regression test for sigp#8426.

When `prune_payloads` is enabled, unaligned checkpoint syncs (where the
anchor block is older than the checkpoint state) were previously failing
to import the anchor block's execution payload.

The new test `reproduction_unaligned_checkpoint_sync_pruned_payload`
reproduces this scenario and asserts that the Beacon Chain initializes
successfully (which confirms the anchor payload was correctly loaded).
@michaelsproul michaelsproul added the ready-for-merge This PR is ready to merge. label Dec 15, 2025
@mergify mergify bot added the queued label Dec 15, 2025
@mergify
Copy link

mergify bot commented Dec 15, 2025

Merge Queue Status

✅ The pull request has been merged at 6f1f4ca

This pull request spent 39 minutes 3 seconds in the queue, including 37 minutes 19 seconds running CI.
The checks were run on draft #8577.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

mergify bot added a commit that referenced this pull request Dec 15, 2025
mergify bot added a commit that referenced this pull request Dec 15, 2025
@mergify mergify bot merged commit 49e1112 into sigp:unstable Dec 15, 2025
36 checks passed
@mergify mergify bot removed the queued label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge This PR is ready to merge. test improvement Improve tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants