Use millis_from_slot_start when comparing against reconstruction deadline
#8246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
added
ready-for-review
michaelsproul
approved these changes
Oct 21, 2025
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Nice catch, and tests look good 👌
michaelsproul
added
ready-for-merge
6 tasks
jchavarri
pushed a commit
to jchavarri/lighthouse
that referenced
this pull request
Oct 21, 2025
…adline (sigp#8246) This recent PR below changes the max reconstruction delay to be a function of slot time. However it uses `seconds_from_slot_start` when comparing (and dropping `nano`), so it might delay reconstruction on networks where the slot time isn’t a multiple of 4, e.g. on gnosis this only happens at 2s instead of 1.25s.: - sigp#8067 (comment) Use `millis_from_slot_start` when comparing against reconstruction deadline Also added some tests for reconstruction delay. Co-Authored-By: Jimmy Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
This recent PR below changes the max reconstruction delay to be a function of slot time. However it uses
seconds_from_slot_startwhen comparing (and droppingnano), so it might delay reconstruction on networks where the slot time isn’t a multiple of 4, e.g. on gnosis this only happens at 2s instead of 1.25s.:Proposed Changes
Use
millis_from_slot_startwhen comparing against reconstruction deadlineAlso added some tests for reconstruction delay.