-
Notifications
You must be signed in to change notification settings - Fork 955
Add eip_3076 crate
#8206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eip_3076 crate
#8206
Conversation
| use std::collections::{HashMap, HashSet}; | ||
| #[cfg(feature = "json")] | ||
| use std::io; | ||
| use types::{Epoch, Hash256, PublicKeyBytes, Slot}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These types imports add a lot of bloat to this crate. It doesn't really matter much right now since eth2 needs types anyway but it might be worth considering some kind of core or primitives feature in types which only imports these basic types, especially if this crate gets used in contexts where the rest of the types aren't already required.
michaelsproul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, I love this!
|
This pull request has been removed from the queue for the following reason: Pull request #8206 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:
You can check the last failing draft PR here: #8211. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
|
@macladson weirdly one of the interchange tests is failing with an out-of-bounds error, can you take a look? 🙏 |
|
Whoops, I de-duplicated the |
|
Hmm still getting failures 1/3 times.. Something about that test is non-deterministic |
|
It was from |
Issue Addressed
#7894
Proposed Changes
Moves the
Interchangeformat fromslashing_protectionand thus removes the dependency onslashing_protectionfrometh2which can now just depend on the slimmereip_3076crate.