Skip to content

Remove deprecated CLI flags and references for v8.0.0 #8142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 5 commits into from
Oct 8, 2025
Merged

Remove deprecated CLI flags and references for v8.0.0 #8142

mergify merged 5 commits into from
Oct 8, 2025

Conversation

@jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Oct 1, 2025 •
edited
Loading

Issue Addressed

Closes #8131

  • Remove deprecated flags from beacon_node/src/cli.rs:
    • eth1-purge-cache
    • eth1-blocks-per-log-query
    • eth1-cache-follow-distance
    • disable-deposit-contract-sync
    • light-client-server
  • Remove deprecated flags from lighthouse/src/main.rs:
    • logfile
    • terminal-total-difficulty-override
    • terminal-block-hash-override
    • terminal-block-hash-epoch-override
    • safe-slots-to-import-optimistically
  • Remove references to deprecated flags in config.rs files
  • Remove warning messages for deprecated flags in main.rs
  • Update/remove related tests in beacon_node.rs

@jimmygchen jimmygchen added ready-for-review The code is ready for review backwards-incompat Backwards-incompatible API change v8.0.0 Q4 2025 Fusaka Mainnet Release labels Oct 1, 2025
@jimmygchen jimmygchen added the low-hanging-fruit Easy to resolve, get it before someone else does! label Oct 1, 2025
chong-he
chong-he reviewed Oct 2, 2025
View reviewed changes
Copy link
Member

@chong-he chong-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some very minor comments.

There is also a mention of --disable-deposit-contract-sync flag in the book, but that will be taken care by #8124

chong-he
chong-he reviewed Oct 6, 2025
View reviewed changes
@jimmygchen @chong-he
Fix formatting.
ec4cfed 
Co-authored-by: chonghe <[email protected]>
chong-he
chong-he approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@chong-he chong-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Oct 8, 2025
@mergify mergify bot added the queued label Oct 8, 2025
mergify bot added a commit that referenced this pull request Oct 8, 2025
@mergify
Merge of #8142
1671f74
@mergify mergify bot mentioned this pull request Oct 8, 2025
Closed
6 tasks
@mergify mergify bot merged commit 2a433bc into sigp:unstable Oct 8, 2025
38 checks passed
@mergify mergify bot removed the queued label Oct 8, 2025
@jimmygchen jimmygchen mentioned this pull request Oct 8, 2025
Closed
jchavarri pushed a commit to jchavarri/lighthouse that referenced this pull request Oct 21, 2025
@jimmygchen @jchavarri
Remove deprecated CLI flags and references for v8.0.0 (sigp#8142)
eacbe9e 
Closes sigp#8131

- [x] Remove deprecated flags from beacon_node/src/cli.rs:
- [x] eth1-purge-cache
- [x] eth1-blocks-per-log-query
- [x] eth1-cache-follow-distance
- [x] disable-deposit-contract-sync
- [x] light-client-server
- [x] Remove deprecated flags from lighthouse/src/main.rs:
- [x] logfile
- [x] terminal-total-difficulty-override
- [x] terminal-block-hash-override
- [x] terminal-block-hash-epoch-override
- [x] safe-slots-to-import-optimistically
- [x] Remove references to deprecated flags in config.rs files
- [x] Remove warning messages for deprecated flags in main.rs
- [x] Update/remove related tests in beacon_node.rs


  


Co-Authored-By: Jimmy Chen <[email protected]>

Co-Authored-By: Jimmy Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chong-he chong-he chong-he approved these changes

Assignees

No one assigned

Labels

backwards-incompat Backwards-incompatible API change low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. v8.0.0 Q4 2025 Fusaka Mainnet Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jimmygchen @chong-he