Only mark block lookups as pending if block is importing from gossip

[dapplion]

Issue Addressed

• PR Consolidate reqresp_pre_import_cache into data_availability_checker #8045 introduced a regression of how lookup sync interacts with the da_checker.

Now in unstable block import from the HTTP API also insert the block in the da_checker while the block is being execution verified. If lookup sync finds the block in the da_checker in NotValidated state it expects a GossipBlockProcessResult message sometime later. That message is only sent after block import in gossip.

I confirmed in our node's logs for 4/4 cases of stuck lookups are caused by this sequence of events:

• Receive block through API, insert into da_checker in fn process_block in put_pre_execution_block
• Create lookup and leave in AwaitingDownload(block in processing cache) state
• Block from HTTP API finishes importing
• Lookup is left stuck

Closes #8104

Proposed Changes

• Send BlockComponentProcessed on HTTP block import #8110 was my initial solution attempt but we can't send the GossipBlockProcessResult event from the http_api crate without adding new channels, which seems messy.

For a given node it's rare that a lookup is created at the same time that a block is being published. This PR solves #8104 by allowing lookup sync to import the block twice in that case.

[eserilev]

Allowing double imports seems fine to me, especially if these are rare. Wondering if there's a metric we could add somewhere to keep track of instances where a block has been imported twice? Can't find any issues with this PR, but another set of eyes on this would be nice.

[jimmygchen]

Just a comment on the doc here:

• I think re-imports wouldn't happen to lookup responses because of duplicate_cache here
  

  lighthouse/beacon_node/network/src/network_beacon_processor/sync_methods.rs

  Line 121 in 78d330e

  let Some(handle) = duplicate_cache.check_and_insert(block_root) else {

• for range sync its unlikely to race with lookups
• http api block imports are much less frequent, so the impact of re-imports is much smaller

[jimmygchen]

Also the impact of duplicate imports is not as bad since michael made the fix in #8050
As described in the PR - longer term we'll have @ethDreamer's block status tracker to prevent block re-imports properly.

[dapplion]

longer term we'll have @ethDreamer's block status tracker to prevent block re-imports properly.

I noticed in this PR that we'll need to re-engineer sync a bit to for that to work. But working with Mark about it

[jimmygchen]

Niice, thanks for fixing this!

The fix looks good to me, be great to add some regression test for this as well.

[jimmygchen]

Merging this now since the fix is simple and makes sense. Great work finding the issue! 🕵️