-
Notifications
You must be signed in to change notification settings - Fork 955
Implement /eth/v1/beacon/blobs endpoint
#8103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jimmygchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey CK, thanks for the PR. I've added my thoughts, let me know what you think and if you have any questions!
|
btw very thorough with the spec compliance, i think the impl great in terms of correctness, and thanks for the test outputs. Nice work 👍 |
|
Bumping this to v8 mainnet release |
This reverts commit 4de15ca.
jimmygchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, thanks @chong-he !
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #8173. You may have to fix your CI before adding the pull request to the queue again. |
|
@mergify requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
* sigp#8085 Co-Authored-By: Tan Chee Keong <[email protected]> Co-Authored-By: chonghe <[email protected]>
Issue Addressed
Proposed change
Rename current
blob_sidecarsendpoint fromget_blobstoget_blob_sidecarsto "give way" to the new get blobs endpoint. I thought this is the better way to have this new get_blobs endpoint name it this way in the code, but I am happy to change if that's not suitable/confusingAdditional Info
Testing results:
Query with:
curl -X 'GET' 'http://localhost:5052/eth/v1/beacon/blobs/12647385' | jqResponse:
Query with
versioned_hashes:curl -X 'GET' \ 'http://localhost:5052/eth/v1/beacon/blobs/12647385?versioned_hashes=0x01171d78b2bd7cf3c3e458f7337f37272bfe6972cdd07b6e12f399a94ff6627c&versioned_hashes=0x011384275182442b69831cc581de3b80fe60b13a8efd870f8b680422087b960e' \ -H 'accept: application/json' | jqResponse: