-
Notifications
You must be signed in to change notification settings - Fork 955
Rename --subscribe-all-data-column-subnets to --supernode and make it visible in help
#8083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… now been officially accepted in the spec. Also make it visible in help in preparation for the fusaka release.
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
pawanjay176
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would be good to get a ✅ from @barnabasbusa as well to make sure we aren't breaking any setups unexpectedly.
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #8086. You may have to fix your CI before adding the pull request to the queue again. |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #8087. You may have to fix your CI before adding the pull request to the queue again. |
|
@mergify requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #8091. You may have to fix your CI before adding the pull request to the queue again. |
depends on sigp/lighthouse#8083 Signed-off-by: Barnabas Busa <[email protected]>
depends on sigp/lighthouse#8083 Signed-off-by: Barnabas Busa <[email protected]>
depends on sigp/lighthouse#8083 Signed-off-by: Barnabas Busa <[email protected]>
Issue Addressed
Rename
--subscribe-all-data-column-subnetsto--supernodeas it's now been officially accepted in the spec. Also make it visible in help in preparation for the fusaka release.https://github.com/ethereum/consensus-specs/blob/dev/specs/fulu/p2p-interface.md#supernodes