Skip to content

Max reconstruction delay as a function of slot time #8067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Oct 17, 2025
Merged

Max reconstruction delay as a function of slot time #8067

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
020d82b
max reconstruction delay as a function of slot time
PoulavBhowmick03 Sep 17, 2025
9d896af
removed float arithmatic and changed to integer
PoulavBhowmick03 Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions beacon_node/beacon_processor/src/scheduler/work_reprocessing_queue.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,9 @@ pub const BACKFILL_SCHEDULE_IN_SLOT: [(u32, u32); 3] = [
(4, 5),
];

/// Trigger reconstruction if we are this many seconds into the current slot
pub const RECONSTRUCTION_DEADLINE: Duration = Duration::from_millis(3000);
/// Fraction of slot duration after which column reconstruction is triggered, makes it easier for
/// different slot timings to have a generalised deadline
pub const RECONSTRUCTION_DEADLINE: (u64, u64) = (1, 4);

/// Messages that the scheduler can receive.
#[derive(AsRefStr)]
Expand Down Expand Up @@ -756,13 +757,17 @@ impl<S: SlotClock> ReprocessQueue<S> {
}
InboundEvent::Msg(DelayColumnReconstruction(request)) => {
let mut reconstruction_delay = QUEUED_RECONSTRUCTION_DELAY;
let slot_duration = self.slot_clock.slot_duration().as_millis() as u64;
let reconstruction_deadline_millis =
(slot_duration * RECONSTRUCTION_DEADLINE.0) / RECONSTRUCTION_DEADLINE.1;
let reconstruction_deadline = Duration::from_millis(reconstruction_deadline_millis);
if let Some(seconds_from_current_slot) =
self.slot_clock.seconds_from_current_slot_start()
Copy link
Member

@jimmygchen jimmygchen Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function only gives us granuarity to the seconds I believe

lighthouse/common/slot_clock/src/lib.rs

Lines 108 to 110 in 522bd9e

.map(|duration_into_slot| {
Duration::from_secs(duration_into_slot.as_secs() % self.slot_duration().as_secs())
})

So on a network like gnosis (5s slot times), reconstruction is only triggered immediately if seconds_from_current_slot_start is 2s

&& let Some(current_slot) = self.slot_clock.now()
&& seconds_from_current_slot >= RECONSTRUCTION_DEADLINE
&& seconds_from_current_slot >= reconstruction_deadline
&& current_slot == request.slot
{
// If we are at least `RECONSTRUCTION_DEADLINE` seconds into the current slot,
// If we are at least `reconstruction_deadline` seconds into the current slot,
// and the reconstruction request is for the current slot, process reconstruction immediately.
reconstruction_delay = Duration::from_secs(0);
}
Expand Down
Loading