Spec Mapping for configs.yml in Lighthouse#7896
Closed
Harsh-Karia wants to merge 4 commits intosigp:unstablefrom
Closed
Spec Mapping for configs.yml in Lighthouse#7896Harsh-Karia wants to merge 4 commits intosigp:unstablefrom
Harsh-Karia wants to merge 4 commits intosigp:unstablefrom
Conversation
… have ethspecify only running on configs.yml.
|
|
Member
|
How do we maintain this? It looks like a massive amount of work from the diff |
…dded regex expression to search directly for CUSTODY_REQUIREMENT
Contributor
Hey @michaelsproul this isn't ready for review yet. We'll close the PR & re-open it later. But to answer your question, I don't expect maintenance to be very difficult. See my answer here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lighthouse Spec Mapping
Proposed Changes
Added all of the file paths and search terms for each of the spec implementations in configs.yml.
Additional Info
Ethspecify checks pass for all implementations except 1:
AMBIGUOUS SEARCH: configs.CUSTODY_REQUIREMENT#fulu | 'CUSTODY_REQUIREMENT:' found 2 times in common/eth2_network_config/built_in_network_configs/mainnet/config.yaml