Skip to content

Optimise parallelism in compute cells operations by zipping first #7574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025
Merged

Optimise parallelism in compute cells operations by zipping first #7574

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2901639
Zip first instead of calling `into_par_iter` on both lists being zipp…
jimmygchen Jun 6, 2025
b7c9d0c
Fix lint
jimmygchen Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions beacon_node/beacon_chain/src/kzg_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,9 @@ pub fn blobs_to_data_column_sidecars<E: EthSpec>(
.collect::<Vec<_>>();

// NOTE: assumes blob sidecars are ordered by index
let blob_cells_and_proofs_vec = blobs
let zipped: Vec<_> = blobs.iter().zip(proof_chunks).collect();
let blob_cells_and_proofs_vec = zipped
.into_par_iter()
.zip(proof_chunks.into_par_iter())
.map(|(blob, proofs)| {
let blob = blob
.as_ref()
Expand Down