-
Notifications
You must be signed in to change notification settings - Fork 930
Add additional mergify rules to automate triaging #7451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this won't fire very often. If someone requests changes, their request for changes hangs around until they dismiss it or re-review.
We can give it a go, but I think what we really need is a way of checking whether all review comments have been addressed. Maybe
#review-threads-unresolved = 0?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(from https://docs.mergify.com/configuration/conditions/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
I had a look at a few open PRs and looks like neither of these would be sufficient
#changes-requested-reviews-by = 0has the issue you mentioned, e.g. feat: add tests for filtering GET /beacon/pool/attestations #7321 has a change requested so it will never fire until a maintainer changes the review status#review-threads-unresolved = 0may cause this rule to fire unintentionally, e.g. chore: account for state availability when fetching sync committees #7435 #7436 just had a change requested, but CI is passing and there's no conflict, therefore mergify will immediately remove thewaiting-on-authorlabel after it's added.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For PRs by external contributors, this rule will never fire automatically because the CI workflow require approval - but it would be useful to automatically update the labels once the a maintainer approve the job and the CI job passes.
For PRs by maintainers, I think it would be easy enough for the author just update the labels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the rules to match for
"#review-requested > 0"instead of the above, so it only fires automatically if a review is requested. This is a workaround for the above two issues, it's not ideal but i think easier than 1. dimissing the review, 2. having to create a thread to avoidwaiting-on-authorfrom getting removed.