Skip to content

Silence Uninitialized warn log on start-up #7411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025
Merged

Silence Uninitialized warn log on start-up #7411

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e10bbbf
Silence uninitialized warn on start-up
macladson May 7, 2025
080c819
Add debug log in uninitialized case
macladson May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions validator_client/beacon_node_fallback/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,12 +486,26 @@ impl<T: SlotClock, E: EthSpec> BeaconNodeFallback<T, E> {

for (result, node) in results {
if let Err(e) = result {
if *e != CandidateError::PreGenesis {
warn!(
error = ?e,
endpoint = %node,
"A connected beacon node errored during routine health check"
);
match e {
// Avoid spamming warns before genesis.
CandidateError::PreGenesis => {}
// Uninitialized *should* only occur during start-up before the
// slot clock has been initialized.
// Seeing this log in any other circumstance would indicate a serious bug.
CandidateError::Uninitialized => {
debug!(
error = ?e,
endpoint = %node,
"A connected beacon node is uninitialized"
);
}
_ => {
warn!(
error = ?e,
endpoint = %node,
"A connected beacon node errored during routine health check"
);
}
}
}
}
Expand Down
Loading