Skip to content

Fix PeerDAS sync scoring#7352

Merged
jimmygchen merged 72 commits intosigp:peerdas-devnet-7from
dapplion:peerdas-sync
May 21, 2025
Merged

Fix PeerDAS sync scoring#7352
jimmygchen merged 72 commits intosigp:peerdas-devnet-7from
dapplion:peerdas-sync

Conversation

@dapplion
Copy link
Copy Markdown
Collaborator

Issue Addressed

Range sync will not penalize the proper peer during PeerDAS sync for invalid column errors

Proposed Changes

  • Propagate errors with enough details to figure out which block component(s) are invalid
  • Track which peer served what in range sync batches
  • Use the above two ^ to downscore the correct peers

Progress

  • Implement
  • Add tests

@mergify
Copy link
Copy Markdown

mergify Bot commented May 16, 2025

Some required checks have failed. Could you please take a look @dapplion? 🙏

@mergify
Copy link
Copy Markdown

mergify Bot commented May 17, 2025

Some required checks have failed. Could you please take a look @dapplion? 🙏

@dapplion
Copy link
Copy Markdown
Collaborator Author

Last remaining CI failure is a clippy warning

error: large size difference between variants
  --> consensus/state_processing/src/per_epoch_processing/epoch_processing_summary.rs:12:1
   |
12 | /   pub enum EpochProcessingSummary<E: EthSpec> {

@dapplion
Copy link
Copy Markdown
Collaborator Author

@mergify
Copy link
Copy Markdown

mergify Bot commented May 19, 2025

Some required checks have failed. Could you please take a look @dapplion? 🙏

@mergify
Copy link
Copy Markdown

mergify Bot commented May 20, 2025

Some required checks have failed. Could you please take a look @dapplion? 🙏

Copy link
Copy Markdown
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can start testing and fix the peer attribution in the other big sync PR

@mergify
Copy link
Copy Markdown

mergify Bot commented May 20, 2025

Some required checks have failed. Could you please take a look @dapplion? 🙏

@mergify
Copy link
Copy Markdown

mergify Bot commented May 20, 2025

Some required checks have failed. Could you please take a look @dapplion? 🙏

@mergify
Copy link
Copy Markdown

mergify Bot commented May 20, 2025

Some required checks have failed. Could you please take a look @dapplion? 🙏

Comment thread beacon_node/beacon_chain/tests/store_tests.rs
Comment thread beacon_node/beacon_chain/src/data_availability_checker.rs
@mergify
Copy link
Copy Markdown

mergify Bot commented May 20, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@pawanjay176
Copy link
Copy Markdown
Member

@jimmygchen Merge at will

Copy link
Copy Markdown
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for pushing this through 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

das Data Availability Sampling ready-for-review The code is ready for review syncing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants