Add additional broadcast validation tests for Fulu/PeerDAS #7325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
added
das
michaelsproul
previously requested changes
Apr 22, 2025
michaelsproul
added
waiting-on-author
eserilev
added
ready-for-review
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
bot
added
waiting-on-author
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
jimmygchen
reviewed
May 20, 2025
eserilev
added
ready-for-review
jimmygchen
reviewed
Jun 25, 2025
jimmygchen
requested changes
Jun 27, 2025
Member
jimmygchen
left a comment
jimmygchen
left a comment
There was a problem hiding this comment.
This is great, i didn't realise the tests can be reused without needing any modification 😄 I think we could probably remove test_spec() in the tests that uses InteractiveTester::<E>::new(None,... as it already defaults to test_spec.
jimmygchen
added
waiting-on-author
jimmygchen
reviewed
Jul 11, 2025
jimmygchen
reviewed
Jul 11, 2025
jimmygchen
reviewed
Jul 11, 2025
jimmygchen
reviewed
Jul 11, 2025
jimmygchen
reviewed
Jul 11, 2025
jimmygchen
reviewed
Jul 11, 2025
…lu-broadcast-validation-tests
jimmygchen
added
ready-for-merge
6 tasks
danielrachi1
pushed a commit
to danielrachi1/lighthouse
that referenced
this pull request
Jul 18, 2025
Closes sigp#6855 Add PeerDAS broadcast validation tests and fix a small bug where `sampling_columns_indices` is none (indicating that we've already sampled the necessary columns) and `process_gossip_data_columns` gets called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #6855
Proposed Changes
Add PeerDAS broadcast validation tests and fix a small bug where
sampling_columns_indicesis none (indicating that we've already sampled the necessary columns) andprocess_gossip_data_columnsgets calledAdditional Info
If theres a better way to format these tests (maybe have CI feed in a list of forks to the relevant tests?) I can do that instead