Fix light client plumbing in beacon processor

[michaelsproul]

Issue Addressed

Our Holesky nodes running with the light client enabled were logging messages about full queues:

Feb 12 22:09:28.949 ERRO Work queue is full queue: unknown_light_client_optimistic_update, queue_len: 128, msg: the system has insufficient resources for load, service: bproc

I thought this might be genuine overload, but it turns out this queue was never being read from!

Proposed Changes

• Rename light-client related queues in the beacon processor for clarity.
• Ensure all light-client related queues are being popped from.

Additional Info

I noticed that the sampling_result_queue is never being read from either, but I've added a TODO(das) to address that in future.

[jimmygchen]

Good catch, LGTM!

[michaelsproul]

For the record: the impact of the bug isn't that we never processing light client updates from gossip. It's that we never process them once queued. It takes a while for the queue to build up, because if the processor is not at capacity, we will still schedule and run processing immediately here:

lighthouse/beacon_node/beacon_processor/src/lib.rs

Lines 1301 to 1302 in 029b4f2

	match work {
	_ if can_spawn => self.spawn_worker(work, idle_tx),

[michaelsproul]

@mergify queue

[mergify]

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 25f804a