Fix BlobsByRange by reverting PR6462 #6526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 772929f.
michaelsproul
added
bug
jimmygchen
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
LGTM! Nice find 🎉
We can revisit the change once #6329 is merged.
jimmygchen
added
ready-for-merge
dapplion
approved these changes
Oct 21, 2024
|
@mergify queue |
🛑 The pull request has been removed from the queue
|
5 tasks
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 9aefb55 |
5 tasks
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
This reverts PR:
That PR accidentally broke
BlobsByRangerequests by adding a non-standard field to the SSZ representation (sent over the network). The result is that peers would not respond to Lighthouse'sBlobsByRangerequests and Lighthouse would be unable to sync.