Skip to content

Penalize peer if missing blobs #6525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dapplion wants to merge 1 commit into from
Closed

Penalize peer if missing blobs #6525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions beacon_node/beacon_chain/src/data_availability_checker/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ impl Error {
pub fn category(&self) -> ErrorCategory {
match self {
Error::SszTypes(_)
| Error::MissingBlobs
| Error::MissingCustodyColumns
| Error::StoreError(_)
| Error::DecodeError(_)
| Error::Unexpected
Expand All @@ -49,6 +47,8 @@ impl Error {
| Error::SlotClockError => ErrorCategory::Internal,
Error::InvalidBlobs { .. }
| Error::InvalidColumn { .. }
| Error::MissingBlobs
| Error::MissingCustodyColumns
Copy link
Copy Markdown
Member

@jimmygchen jimmygchen Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The category change makes sense but it doesn't look like we use this to determine peer penalty.

Related issue:
#4546

I think we'll need to handle BlockError::AvailabilityCheck in handle_failed_chain_segment:

lighthouse/beacon_node/network/src/network_beacon_processor/sync_methods.rs

Line 711 in ee7fca3

fn handle_failed_chain_segment(&self, error: BlockError) -> Result<(), ChainSegmentFailed> {

Copy link
Copy Markdown
Member

@jxs jxs Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems we use Jimmy, category() is called on:

lighthouse/beacon_node/network/src/sync/block_lookups/mod.rs

Lines 580 to 605 in 2e0eb6d

BlockError::AvailabilityCheck(e)
if e.category() == AvailabilityCheckErrorCategory::Internal =>
{
// There errors indicate internal problems and should not downscore the peer
warn!(self.log, "Internal availability check failure"; "block_root" => ?block_root, "error" => ?e);
// Here we choose *not* to call `on_processing_failure` because this could result in a bad
// lookup state transition. This error invalidates both blob and block requests, and we don't know the
// state of both requests. Blobs may have already successfullly processed for example.
// We opt to drop the lookup instead.
Action::Drop
}
other => {
debug!(self.log, "Invalid lookup component"; "block_root" => ?block_root, "component" => ?R::response_type(), "error" => ?other);
let peer_id = request_state.on_processing_failure()?;
cx.report_peer(
peer_id,
PeerAction::MidToleranceError,
match R::response_type() {
ResponseType::Block => "lookup_block_processing_failure",
ResponseType::Blob => "lookup_blobs_processing_failure",
},
);
Action::Retry

with Lion's change Error::MissingBlobs and Error::MissingCustodyColumns are now reported as ErrorCategory::Malicious instead of ErrorCategory::Internal which makes it so that those nodes get reported via report_peer

| Error::ReconstructColumnsError { .. }
| Error::BlobIndexInvalid(_)
| Error::DataColumnIndexInvalid(_)
Expand Down