Strict match of errors in backfill sync#6520
Merged
mergify[bot] merged 2 commits intosigp:unstablefrom Nov 5, 2024
Merged
Conversation
pawanjay176
added
ready-for-merge
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 3838897 |
This was referenced Nov 5, 2024
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
* Strict match of errors in backfill sync * Fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Same spirit as
Handling errors in sync with a fallback match is not great. In the case of backfill sync it's very easy to fix! =D
Proposed Changes
Turns out that its processing returns almost only variants of
HistoricalBlockError, so I changedimport_historical_block_batchto returnHistoricalBlockErrorinstead ofBeaconChainError.All logic is the same, just made the match on network beacon processor cleaner a bit cleaner.