Detect invalid proposer signature on RPC block processing#6519
Merged
mergify[bot] merged 4 commits intosigp:unstablefrom Jan 28, 2025
Merged
Detect invalid proposer signature on RPC block processing#6519mergify[bot] merged 4 commits intosigp:unstablefrom
mergify[bot] merged 4 commits intosigp:unstablefrom
Conversation
pawanjay176
approved these changes
Oct 31, 2024
pawanjay176
approved these changes
Nov 1, 2024
Member
|
Tests are failing |
jimmygchen
added
waiting-on-author
dapplion
force-pushed
the
detect-error-proposer-signature
branch
from
4313743 to
049f754
Compare
Collaborator
Author
|
This is ready for review. Motivation: used by #6321 to not re-download a block that has invalid body signature(s) |
dapplion
added
ready-for-review
pawanjay176
approved these changes
Jan 27, 2025
Member
pawanjay176
left a comment
pawanjay176
left a comment
There was a problem hiding this comment.
Looks good mostly, not sure of the necessity of the Unknown error variant
Co-authored-by: Pawan Dhananjay <pawandhananjay@gmail.com>
pawanjay176
approved these changes
Jan 28, 2025
pawanjay176
added
ready-for-merge
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Complements
by detecting if the proposer signature is valid or not during RPC block processing. In lookup sync, if the invalid signature signature is the proposer signature, it's not deterministic on the block root. So we should only penalize the sending peer and retry. Otherwise, if it's on the body we should drop the lookup and penalize all peers that claim to have imported the block