Skip to content

Simplify hashing in shuffling #6483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2024
Merged

Simplify hashing in shuffling #6483

merged 3 commits into from
Oct 14, 2024

Conversation

@michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Oct 13, 2024

Proposed Changes

Remove some bounds checks from swap_or_not_shuffle by using the infallible method Hash256::from rather than Hash256::from_slice which does runtime checks and can panic.

This didn't seem to make a difference to the benchmarks, but I think it's a nice cleanup regardless.

@michaelsproul michaelsproul added ready-for-review The code is ready for review code-quality low-hanging-fruit Easy to resolve, get it before someone else does! labels Oct 13, 2024
@michaelsproul
Copy link
Member Author

michaelsproul commented Oct 13, 2024 •
edited
Loading

The swap_or_not_shuffle benchmarks didn't actually compile, so I've fixed the dep issues and made it so that make lint also checks benchmarks.

jimmygchen
jimmygchen approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Oct 14, 2024
@michaelsproul
Copy link
Member Author

michaelsproul commented Oct 14, 2024

@mergify queue

@mergify
Copy link

mergify bot commented Oct 14, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 2e440df

@mergify mergify bot merged commit 2e440df into sigp:unstable Oct 14, 2024
29 checks passed
@michaelsproul michaelsproul deleted the simplify-swap-or-not branch October 17, 2024 04:36
chong-he pushed a commit to chong-he/lighthouse that referenced this pull request Nov 26, 2024
@michaelsproul @chong-he
Simplify hashing in shuffling (sigp#6483)
a01c241 
* Simplify hashing in shuffling

* Fix benchmark deps

* Check benchmarks when linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees

No one assigned

Labels

code-quality infra-ci low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. test improvement Improve tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelsproul @jimmygchen