Electra attestations #5712 review - #5940

Merged

realbigsean merged 30 commits into

sigp:electra_attestation_changesfrom

dapplion:electra_attestation_changes_lionreview

Jun 19, 2024

Commits on Jun 19, 2024

De-dup attestation constructor logic
dapplion
committed
d87541c
Remove unwraps in Attestation construction
dapplion
committed
dd0d5e2
Dedup match_attestation_data
dapplion
committed
3ec21a2
Remove outdated TODO
dapplion
committed
795eff9
Use ForkName Ord in fork-choice tests
dapplion
committed
960f8c5
Use ForkName Ord in BeaconBlockBody
dapplion
committed
1d0e3f4
Make to_electra not fallible
dapplion
committed
5acc052
Remove TestRandom impl for IndexedAttestation
dapplion
committed
4f08f6e
Remove IndexedAttestation faulty Decode impl
dapplion
committed
f049285
Drop TestRandom impl
dapplion
committed
5070ab2
Add PendingAttestationInElectra
dapplion
committed
45d007a
Indexed att on disk (#35)

committed
9e84779
add electra fork enabled fn to ForkName impl (#36)

eserilev
authored and
dapplion
committed
7af3f2e
Update common/eth2/src/types.rs

dapplion
and
ethDreamer
committed
2634a1f
Dedup attestation constructor logic in attester cache
dapplion
committed
dec7cff
Use if let Ok for committee_bits
dapplion
committed
6a4d842
Dedup Attestation constructor code
dapplion
committed
6f0b784
Diff reduction in tests
dapplion
committed
444cd62
Fix beacon_chain tests
dapplion
committed
d264736
Diff reduction
dapplion
committed
7521f97
Use Ord for ForkName in pubsub
dapplion
committed
4d3edfe
Resolve into_attestation_and_indices todo
dapplion
committed
7fce143
Remove stale TODO
dapplion
committed
4d4c268
Fix beacon_chain tests
dapplion
committed
370d511
Test spec invariant
dapplion
committed
cbb7c5d
Use electra_enabled in pubsub
dapplion
committed
70a2d4d
Remove get_indexed_attestation_from_signed_aggregate
dapplion
committed
9e6e76f
Use ok_or instead of if let else
dapplion
committed
a8d8989
committees are sorted
dapplion
committed
d67270f
remove dup method `get_indexed_attestation_from_committees`
realbigsean
committed
3977b92

Navigation Menu

Electra attestations #5712 review - #5940

Electra attestations #5712 review#5940
realbigsean merged 30 commits into
sigp:electra_attestation_changesfrom
dapplion:electra_attestation_changes_lionreview

Commits on Jun 19, 2024

De-dup attestation constructor logic

Remove unwraps in Attestation construction

Dedup match_attestation_data

Remove outdated TODO

Use ForkName Ord in fork-choice tests

Use ForkName Ord in BeaconBlockBody

Make to_electra not fallible

Remove TestRandom impl for IndexedAttestation

Remove IndexedAttestation faulty Decode impl

Drop TestRandom impl

Add PendingAttestationInElectra

Indexed att on disk (#35)

add electra fork enabled fn to ForkName impl (#36)

Update common/eth2/src/types.rs

Dedup attestation constructor logic in attester cache

Use if let Ok for committee_bits

Dedup Attestation constructor code

Diff reduction in tests

Fix beacon_chain tests

Diff reduction

Use Ord for ForkName in pubsub

Resolve into_attestation_and_indices todo

Remove stale TODO

Fix beacon_chain tests

Test spec invariant

Use electra_enabled in pubsub

Remove get_indexed_attestation_from_signed_aggregate

Use ok_or instead of if let else

committees are sorted

remove dup method `get_indexed_attestation_from_committees`