Revert libp2p metrics (#4870) #5265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0c3fef5.
paulhauner
approved these changes
Feb 19, 2024
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
LGTM, thank you 🙏
@jxs do you mind giving this a quick eyeball please?
paulhauner
added a commit
that referenced
this pull request
Feb 19, 2024
Squashed commit of the following: commit 28fe6be Author: Jimmy Chen <[email protected]> Date: Tue Feb 20 10:04:56 2024 +1100 Revert "improve libp2p connected peer metrics (#4870)" This reverts commit 0c3fef5.
Merged
Member
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 50c423a |
paulhauner
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0c3fef5.
Issue Addressed
#4870 included some improvements to libp2p peers metrics, however they aren't part of the "standard" metrics (https://github.com/ethereum/beacon-metrics/blob/master/metrics.md).
To avoid breaking the existing metrics, we are reverting this PR before the release and will re-introduce the metrics under a different label to maintain standard-compat.