Skip to content

Quieten gossip republish logs #5235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2024
Merged

Quieten gossip republish logs #5235

merged 1 commit into from
Feb 15, 2024

Conversation

@michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Feb 15, 2024

Issue Addressed

Closes #5197

Proposed Changes

  • Drop the severity of the log message for duplicates from WARN to DEBG
  • Drop the severity of the log message for successful publication from WARN to DEBG

@michaelsproul michaelsproul added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! UX-and-logs v5.0.0 Q1 2024 labels Feb 15, 2024
@michaelsproul michaelsproul changed the title Duplicate republish warn Quieten gossip republish logs Feb 15, 2024
AgeManning
AgeManning approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 15, 2024
@michaelsproul
Copy link
Member Author

michaelsproul commented Feb 15, 2024

@Mergifyio queue

@mergify
Copy link

mergify bot commented Feb 15, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 7c23625

mergify bot added a commit that referenced this pull request Feb 15, 2024
@mergify
Merge of #5235
ed33058
This was referenced Feb 15, 2024
Closed
Merged
Merged
mergify bot added a commit that referenced this pull request Feb 15, 2024
@mergify
Merge of #5235
baedb69
@mergify mergify bot mentioned this pull request Feb 15, 2024
Closed
5 tasks
@mergify mergify bot merged commit 7c23625 into sigp:unstable Feb 15, 2024
mergify bot added a commit that referenced this pull request Feb 15, 2024
@mergify
Merge of #5235
aa44c0d
@michaelsproul michaelsproul deleted the duplicate-republish-warn branch February 15, 2024 07:04
@paulhauner paulhauner mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AgeManning AgeManning AgeManning approved these changes

Assignees

No one assigned

Labels

low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. UX-and-logs v5.0.0 Q1 2024

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelsproul @AgeManning