Fix failing cargo-udeps #5203
Merged
Fix failing cargo-udeps #5203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
waiting-on-author
michaelsproul
approved these changes
Feb 6, 2024
michaelsproul
added
ready-for-merge
Member
|
Lets open an issue to remove the patch before 5.0 (if possible) too |
Member
Author
|
Thanks, raised #5204 |
Member
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 5cc29e4 |
This was referenced Feb 6, 2024
danielrachi1
pushed a commit
to danielrachi1/lighthouse
that referenced
this pull request
Feb 14, 2024
* Attempt to fix nightly build. * Update Cargo.toml to pin a commit * Update Cargo.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
CI is currently blocked as the
curve25519-daleknightly build has started failing sincerustc 1.78.0-nightly (f067fd608 2024-02-05):https://github.com/sigp/lighthouse/actions/runs/7793900607/job/21254345866
I've submitted a PR to fix this: dalek-cryptography/curve25519-dalek#619
This PR patches the
curve25519-dalekand should be reverted once they release a fix for this.