Skip to content

enable doppelganger tests for deneb #5137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 15, 2024
Merged

enable doppelganger tests for deneb #5137

merged 4 commits into from
Feb 15, 2024

Conversation

@realbigsean
Copy link
Member

@realbigsean realbigsean commented Jan 29, 2024

Issue Addressed

Resolves #4847

Proposed Changes

  • this required changing the eth1 block hash to make sure it still matched the genesis block
  • had to update the new-testnet command with support for later forks
  • also added geth logging in the testnet

@realbigsean realbigsean added ready-for-review The code is ready for review deneb labels Jan 29, 2024
@realbigsean
Copy link
Member Author

realbigsean commented Jan 29, 2024

I think this is failing because lcli needs to be re-installed? maybe geth?

@realbigsean realbigsean added the v5.0.0 Q1 2024 label Jan 31, 2024
@jimmygchen
Copy link
Member

jimmygchen commented Feb 2, 2024

Could be the lcli, since we don't re-build it when running CI on self-hosted runners:

lighthouse/.github/workflows/test-suite.yml

Lines 311 to 313 in c7e5dd1

- name: Install lcli
if: env.SELF_HOSTED_RUNNERS == 'false'
run: make install-lcli

Might have to temporarily turn this off and batch another PR to turn it back on 🙈

@realbigsean realbigsean mentioned this pull request Feb 7, 2024
Closed
@realbigsean
Copy link
Member Author

realbigsean commented Feb 7, 2024

Might have to temporarily turn this off and batch another PR to turn it back on 🙈

just commented it out here: 05119ad

dapplion
dapplion reviewed Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should call state.fork_name or similar assertion at the end to double-check that the state has been advanced to the proper genesis fork.

@michaelsproul
Copy link
Member

michaelsproul commented Feb 15, 2024

You should call state.fork_name or similar assertion at the end to double-check that the state has been advanced to the proper genesis fork.

I just pushed this check. Let's merge once CI passes

@realbigsean realbigsean added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 15, 2024
@michaelsproul
Copy link
Member

michaelsproul commented Feb 15, 2024

@Mergifyio queue

@mergify
Copy link

mergify bot commented Feb 15, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 1711b80

mergify bot added a commit that referenced this pull request Feb 15, 2024
@mergify
Merge of #5137
83475fe
This was referenced Feb 15, 2024
Closed
Merged
Merged
Merged
Merged
mergify bot added a commit that referenced this pull request Feb 15, 2024
@mergify
Merge of #5137
f7ed128
@mergify mergify bot mentioned this pull request Feb 15, 2024
Closed
14 tasks
@mergify mergify bot merged commit 1711b80 into sigp:unstable Feb 15, 2024
@Arvmor Arvmor mentioned this pull request Feb 25, 2024
Merged
@realbigsean realbigsean mentioned this pull request Mar 5, 2024
Closed
@chong-he chong-he mentioned this pull request Mar 12, 2024
Closed
@macladson macladson mentioned this pull request Mar 18, 2024
Merged
michaelsproul added a commit that referenced this pull request Apr 30, 2024
@michaelsproul
Uncomment self_hosted_runner after PR Merge #5137 (#5291)
d90ea93 
Squashed commit of the following:

commit a62a8fc
Merge: 86ceda6 40d4126
Author: realbigsean <[email protected]>
Date:   Mon Apr 29 14:20:23 2024 -0400

    Merge branch 'unstable' into fix_todo

commit 86ceda6
Author: Arvin Morawej <[email protected]>
Date:   Sun Feb 25 02:20:16 2024 -0500

    Uncomment self_hosted_runner after PR Merge #5137
mergify bot pushed a commit that referenced this pull request Apr 30, 2024
@Arvmor
Uncomment self_hosted_runner after PR Merge #5137 (#5291)
aea02c6 
* Uncomment self_hosted_runner after PR Merge #5137

* Merge branch 'unstable' into fix_todo

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into fix_todo
ethDreamer added a commit that referenced this pull request May 2, 2024
@ethDreamer @realbigsean
@macladson @dapplion @pawanjay176 @rkrasiuk @eserilev @antondlr @jimmygchen @Arvmor @AgeManning @jxs @michaelsproul
Electra attestation changes (#5697)
cd0f08b 
* Fix execution integration tests (#5647)

* update waiting status

* revert to old nethermind version

* Add electra presets to beacon API (#5630)

* add presets to API

* add extra fields to config spec in beacon API

* remove unused

* add mainnet presets for gnosis and fix minimal preset default values

* Rename `Merge` to `Bellatrix` (#5601)

* Rename Merge to Bellatrix

* Remove tree-hash-cache which got readded from the rebase

* Deterministic block generation for tests (#5654)

* Deterministic block generation for tests

* Electra other containers (#5652)

* add new fields to execution payload and header

* beacon state changes

* partial beacon state

* safe arith in upgrade to electra

* initialize balances cache in interop genesis state

* Revert "initialize balances cache in interop genesis state"

This reverts commit c60b522.

* always initialize balances cache if necessary in electra upgrade

* build cache earlier

* fix block test

* per fork NUM_FIELDS_POW2

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into electra-other-containers

* fix lints

* get fields based on post state, as is spec'd

* fix type and move cache build

* Add more electra helpers (#5653)

* Add new helpers

* Fix some stuff

* Fix compilation errors

* lint

* Address review

* Ignore gossip blob already imported (#5656)

* Ignore gossip blob already imported

* Beta compiler fix (#5659)

* fix beta compiler compilation

* remove unused import

* Revert "remove unused import"

This reverts commit 0bef36b.

* Revert "fix beta compiler compilation"

This reverts commit 23152cf.

* rename ununsed fields

* allow dead code on some error variants

* remove unused blob download queue

* add back debug to backfill error

* more allow dead code on errors

* fix(validator_client): raise soft fd limit (#4796)

* fix(validator_client): raise soft fd limit

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into rkrasiuk/raise-vc-fdlimit

* cargo lock

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into rkrasiuk/raise-vc-fdlimit

* Proposer and attester slashing sse events (#5327)

* default vc to block v3 endpoint and deprecate block-v3 flag

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into unstable

* add proposer and attester event variants

* add TOOOs

* add tests, event triggers

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events

* revert

* revert

* remove double event tracking

* Merge branch 'unstable' into proposer-and-attester-slashing-sse-events

* remove todo, fix test

* resolve merge conflicts

* Merge branch 'proposer-and-attester-slashing-sse-events' of https://github.com/eserilev/lighthouse into proposer-and-attester-slashing-sse-events

* leftover debugging

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events

* pin macos release runner to `macos-13` (#5665)

* pin macos release runner to `macos-13`

* Update .github/workflows/release.yml

* Remove snapshot cache related code (#5661)

* Remove snapshot cache and other references.

* Fix default state cache size in docs

* Remove cache miss comment entirely

* Add state cache CLI tests

* Uncomment self_hosted_runner after PR Merge #5137 (#5291)

* Uncomment self_hosted_runner after PR Merge #5137

* Merge branch 'unstable' into fix_todo

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into fix_todo

* Only `portable` builds (binaries) (#5615)

* release workflow: portable builds by default

* Delete outdated comment

* Merge branch 'unstable' into portable-builds-binaries

# Conflicts:
#	.github/workflows/release.yml

* Merge parent and current sync lookups (#5655)

* Drop lookup type trait for a simple arg

* Drop reconstructed for processing

* Send parent blocks one by one

* Merge current and parent lookups

* Merge current and parent lookups clean up todos

* Merge current and parent lookups tests

* Merge remote-tracking branch 'origin/unstable' into sync-merged-lookup

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into sync-merged-lookup

* fix compile after merge

* #5655 pr review (#26)

* fix compile after merge

* remove todos, fix typos etc

* fix compile

* stable rng

* delete TODO and unfilled out test

* make download result a struct

* enums instead of bools as params

* fix comment

* Various fixes

* Track ignored child components

* Track dropped lookup reason as metric

* fix test

* add comment describing behavior of avail check error

*  update ordering

*  delete spammy log (#5672)

*  delete spammy log

* Ensure block only range requests don't fail on download (#5675)

* ensure pruned blobs don't fail on download

* Typo

* Improve ENR updates (#5483)

* Improve ENR updates

* forever fmt

* Appease my old friend clippy

* Merge network unstable

* Check da_checker before doing a block lookup request (#5681)

* Check da_checker before doing a block lookup request

* Ensure consistent handling of lookup result

* use req resp pre import cache rather than da checker

* Update Cargo.lock (#5670)

* update rust-yamux

* update Cargo.lock

* Merge branch 'unstable' of github.com:jxs/lighthouse into update-cargo

* Merge branch 'unstable' of github.com:sigp/lighthouse into update-cargo

* update to new libp2p versions

* Add metric for current epoch total balance (#5688)

* Add metric for current epoch total balance

---------

Co-authored-by: realbigsean <[email protected]>
Co-authored-by: Mac L <[email protected]>
Co-authored-by: Lion - dapplion <[email protected]>
Co-authored-by: Pawan Dhananjay <[email protected]>
Co-authored-by: Roman Krasiuk <[email protected]>
Co-authored-by: Eitan Seri-Levi <[email protected]>
Co-authored-by: antondlr <[email protected]>
Co-authored-by: Jimmy Chen <[email protected]>
Co-authored-by: Ærvin <[email protected]>
Co-authored-by: Age Manning <[email protected]>
Co-authored-by: João Oliveira <[email protected]>
Co-authored-by: Michael Sproul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dapplion dapplion dapplion left review comments

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees

No one assigned

Labels

deneb ready-for-merge This PR is ready to merge. v5.0.0 Q1 2024

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@realbigsean @jimmygchen @michaelsproul @dapplion