Skip to content

Conversation

@macladson
Copy link
Member

Issue Addressed

unstable does not currently compile:

error[E0433]: failed to resolve: could not find `EnvFilter` in `tracing_subscriber`
   --> lighthouse/src/main.rs:369:50
    |
369 |     let filter_layer = match tracing_subscriber::EnvFilter::try_from_default_env()
    |                                                  ^^^^^^^^^ could not find `EnvFilter` in `tracing_subscriber`

I believe the issue is that tracing_subscriber::EnvFilter relies on the env-filter feature which wasn't added in #4979

Proposed Changes

Add the env-filter feature flag to the tracing-subscriber crate.

@macladson macladson added the ready-for-review The code is ready for review label Jan 16, 2024
@macladson
Copy link
Member Author

Closing since this will be fixed once #4988 merges.

@macladson macladson closed this Jan 16, 2024
@macladson macladson deleted the fix-env-filter branch January 16, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review The code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant