Remove custom SSZ beacon states route #5065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcph4
added
work-in-progress
jmcph4
added
ready-for-review
Contributor
Author
|
Remaining CI fails seem to be Redis-related so I'm pushing this to review. |
Merged
dapplion
approved these changes
Jan 29, 2024
Collaborator
dapplion
left a comment
dapplion
left a comment
There was a problem hiding this comment.
LGTM, can you rebase on latest unstable to re-try CI?
michaelsproul
added
ready-for-merge
Member
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at abeb358 |
This was referenced Jan 29, 2024
merge queue: embarking unstable (c7e5dd1) and [#5103 + #5135 + #5120 + #5065 + #5018] together
#5139
Closed
danielrachi1
pushed a commit
to danielrachi1/lighthouse
that referenced
this pull request
Feb 14, 2024
* Remove SSZ state root route * Remove SSZ states route from client impl * Patch tests * Merge branch 'unstable' into 5063-delete-ssz-state-route * Further remove dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #5063
Proposed Changes
get_lighthouse_beacon_states_sszfrom the HTTP APIcommon::eth2::BeaconNodeHttpClient::get_lighthouse_beacon_states_sszAdditional Info
N/A