Add flag to disable warning logs for duplicate gossip messages #5009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Add a flag to disable warning logs when gossipsub returns a
Duplicateerror.The original WARN level log is useful for detecting a duplicate validator key running elsewhere. However, this may result in excessive WARN logs if the validator is broadcasting messages to multiple beacon nodes via the validator client
--broadcastflag. In this case, disabling these warn logs may be useful.When the new
--disable-duplicate-warn-logsflag is present, these duplicate messages are logged at DEBUG level. This PR additional adds thetopic.kindin the log message to help identify the type of duplicate message being sent.