Beacon block - #50
Merged
Merged
Conversation
- Update types::block - Update ssz_helpers::SszBlock - Update db::stores::block_store - Add new fields to types::Block - Update SszBlock as per new Block fields
- Implement generic list decoding> - Expose `encode` mod. - Add convenience encoding function.
- Block -> BeaconBlock - Updates to SszBeaconBlock
Member
Author
|
|
Member
Author
|
Ok, this is ready for review! The diff is much smaller now #33 has been merged. See PR description for list of changes. |
HCastano
reviewed
Oct 18, 2018
| }; | ||
|
|
||
| pub const MIN_SSZ_BLOCK_LENGTH: usize = { | ||
| 8 + // slot |
There was a problem hiding this comment.
Why not do something like const SLOT: usize = 8; for all the fields?
Member
Author
|
Good call, will do.
Thanks!
…On Thu, 18 Oct 2018 at 12:46 pm, Hernando Castano ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In beacon_chain/types/src/beacon_block.rs
<#50 (comment)>:
> @@ -0,0 +1,150 @@
+use super::Hash256;
+use super::attestation_record::AttestationRecord;
+use super::special_record::SpecialRecord;
+use super::ssz::{
+ Encodable,
+ Decodable,
+ DecodeError,
+ SszStream,
+};
+
+pub const MIN_SSZ_BLOCK_LENGTH: usize = {
+ 8 + // slot
Why not do something like const SLOT: usize = 8; for all the fields?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#50 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGWiNM8XtiTtRQJ1yto1zPcvSXZuB-9cks5ul91cgaJpZM4XbkFB>
.
|
This was referenced Oct 20, 2018
Merged
Closed
mergify Bot
pushed a commit
that referenced
this pull request
Jun 15, 2026
Tighten allowed slots for proposer index computation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#49
Proposed Changes
Block->BeaconBlock, globallyBeaconBlock(ancestors, specials, etc)SszBeaconBlockas per new struct layoutAdditional Info
This is a work-in-progress, please do not review yet.
Please do not merge before #33 is merged.